votable: Add support for VOTable 1.6 UTF-8 char encoding #18987
+307
−56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a draft with a purpose of showing one possible implementation of adding VOTable 1.6 UTF-8 character encoding support in the
Charconverter. VOTable 1.6 changed thechardatatype semantics:arraysizenow specifies byte length (not character count) and explicitly supports UTF-8 encoding.PR'ing this early for visibility and iteration, looking for feedback on design decisions and current version.
Changes
Charconverter to detect VOTable 1.6+ viaversion_1_6_or_laterconfig flagformat="O") for UTF-8 fields_binparse_fixed,_binoutput_fixed)_binoutput_fixedto prevent incomplete multi-byte sequencesFixes #18515