Repository navigation
Fix PyAssimp under Python >= 3.12 and macOS library search support - #5397
Merged
Merged
Conversation
kimkulling
approved these changes
Dec 31, 2023
kimkulling
left a comment
Member
There was a problem hiding this comment.
Looks fine for me. Thanks for your help.
Contributor
Author
|
Sorry if I'm misunderstanding the contribution process somehow but is there something else I should be doing before this is merged? I check in and merge master occasionally to keep the CI checks happy but not sure otherwise. |
Member
|
Merged, thanks a lot for your contribution. |
kimkulling
added a commit
that referenced
this pull request
Jul 1, 2026
…5397) * Fix PyAssimp under Python >= 3.12 * Make PyAssimp search DYLD_LIBRARY_PATH under macOS --------- Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 removed the
distutilsmodule (https://docs.python.org/3.10/library/distutils.html) which was being used to check for Anaconda library paths - conditionally disabling this code depending on the Python version is a quick-fix, though modern Python has cleverer package resolution techniques which we could use in the future.This ties into the fact that PyAssimp failed to search the macOS
DYLD_LIBRARY_PATH(which acts similarly toLD_LIBRARY_PATH) when looking for Assimp.Hopefully these tide over PyAssimp until a better library resolution mechanism can be worked out.