Skip to content

Fix X importer breakage introduced in commit f844c33 - #5372

Merged
kimkulling merged 5 commits into
assimp:masterfrom
tellypresence:fix-x-importer-breakage-introduced-in-f844c33
Feb 4, 2024
Merged

kimkulling merged 5 commits into
assimp:masterfrom
tellypresence:fix-x-importer-breakage-introduced-in-f844c33

Conversation

@tellypresence

Copy link
Copy Markdown
Collaborator

Comment out new conditional which caused massive breakage as detailed in #5332

Comment out boneIdx conditional which caused massive breakage

@kimkulling kimkulling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out.

@kimkulling
kimkulling merged commit 005399a into assimp:master Feb 4, 2024
@kimkulling

Copy link
Copy Markdown
Member

Merged, thanks a lot for your contribution.

kimkulling added a commit that referenced this pull request Jul 1, 2026
* Update XFileImporter.cpp

Comment out boneIdx conditional which caused massive breakage

* Update XFileImporter.cpp

Fix typo

* Update XFileImporter.cpp

Dummy whitespace change to attempt to re-trigger failing CI tests

---------

Co-authored-by: Steve M <praktique-tellypresence@yahoo.com>
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants