Skip to content

FBXMeshGeometry: solve issue #5116 using patch provided by darktjm - #5333

Merged
kimkulling merged 2 commits into
assimp:masterfrom
stephengold:sgold/issue/5116
Dec 4, 2023
Merged

kimkulling merged 2 commits into
assimp:masterfrom
stephengold:sgold/issue/5116

Conversation

@stephengold

Copy link
Copy Markdown
Contributor

This implements the fix for issue #5116 that was proposed by @darktjm on 8 September.

@kimkulling kimkulling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@kimkulling

Copy link
Copy Markdown
Member

Thanks a lot for your PR! And sorry for my late response. I am trying to help keep this project running at night. Currently, I am not good at it.

@kimkulling

Copy link
Copy Markdown
Member

@kimkulling
kimkulling merged commit 769e82c into assimp:master Dec 4, 2023
@kimkulling

Copy link
Copy Markdown
Member

Merged, thanks a lot for your contribution.

@stephengold

Copy link
Copy Markdown
Contributor Author

Thanks, @kimkulling. I've acted as release manager for other GitHub projects and know it can get overwhelming. I encourage work at your own pace and not allow anyone to rush you. The alternative is burnout.

In my opinion, tjm's sarcastic comments at 5116 were unprofessional and uncalled for. I hope you didn't take them to heart. In my opinion, the right path is to let go of one's ego and focus on what's best for the project. In this case, that means accepting tjm's help and crediting them for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants