Skip to content

pull-requests - raise TypeError and better docs #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iartarisi wants to merge 2 commits into from
Closed

pull-requests - raise TypeError and better docs #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f64b16
cleared documentation for the project parameter
iartarisi Jul 12, 2011
d6e7806
raise TypeError when creating pull requests if one of the alternative…
iartarisi Jul 12, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion github2/pull_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def create(self, project, base, head, title=None, body=None, issue=None):
issue. If an ``issue`` parameter is supplied the pull request is
attached to that issue, else a new pull request is created.

:param str project: Github project
:param str project: the Github project to send the pull request to
:param str base: branch changes should be pulled into
:param str head: branch of the changes to be pulled
:param str title: title for pull request
Expand All @@ -67,6 +67,10 @@ def create(self, project, base, head, title=None, body=None, issue=None):
post_data["title"] = title
if body:
post_data["body"] = body
else:
raise TypeError("You must either specify a title for the "
"pull request or an issue number to which the "
"pull request should be attached.")
pull_request_data = [("pull[%s]" % k, v) for k, v in post_data.items()]
return self.get_value(project, post_data=dict(pull_request_data),
filter="pull", datatype=PullRequest)
Expand Down