Skip to content

Pagination support for commits. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svetlyak40wt wants to merge 4 commits into from
Closed

Pagination support for commits. #24

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4157bd9
Paging support for commit list using optional 'page' argument.
svetlyak40wt Dec 8, 2010
94e25da
Paging support for commit list using optional 'page' argument.
svetlyak40wt Dec 8, 2010
7c9680b
Merge branch 'master' of github.com:svetlyak40wt/python-github2
svetlyak40wt Jan 4, 2011
f337f3c
Added method 'iter' for commits. It uses pagerator library to iterate…
svetlyak40wt Jan 5, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions github2/commits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import pagerator
from github2.core import BaseData, GithubCommand, Attribute, DateAttribute


Expand Down Expand Up @@ -26,9 +27,23 @@ def __repr__(self):
class Commits(GithubCommand):
domain = "commits"

def list(self, project, branch="master", file=None):
def list(self, project, branch="master", file=None, page = None):
post_data = {}
if page is not None:
post_data['page'] = page
return self.get_values("list", project, branch, file,
filter="commits", datatype=Commit)
filter="commits", datatype=Commit,
post_data=post_data)

def iter(self, project, branch="master", file=None):
return pagerator.IterableQuery(
lambda page: self.get_values(
"list", project, branch, file,
filter="commits", datatype=Commit,
post_data=dict(page=page+1)
),
35 # page_size hardcoded in the GitHub
)

def show(self, project, sha):
return self.get_value("show", project, sha,
Expand Down