Skip to content

Updated ConfirmAsync so it uses new DefaultUseYesNo property as the ConfirmConfig overload does - #804

Merged
aritchie merged 1 commit into
aritchie:masterfrom
cytoph:master
Apr 10, 2022
Merged

Updated ConfirmAsync so it uses new DefaultUseYesNo property as the ConfirmConfig overload does#804
aritchie merged 1 commit into
aritchie:masterfrom
cytoph:master

Conversation

@cytoph

@cytoph cytoph commented Dec 20, 2021

Copy link
Copy Markdown

Description of Change

In my last PR I sadly forgot to also let the ConfirmAsync overload without ConfirmConfig parameter make use of the new DefaultUseYesNo property. This PR changes that.

Issues Resolved

Fixes that using ConfirmAsync with and without ConfirmConfig parameter will result in different button texts when using DefaultUseYesNo = true and not setting OkText and/or CancelText.

API Changes

None

Platforms Affected

  • All

Behavioral Changes

ConfirmAsync with and without ConfirmConfig parameter will now result in the same output (as originally intended), when using DefaultUseYesNo = true and not providing OkText and/or CancelText.

PR Checklist

  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@cytoph

cytoph commented Mar 31, 2022

Copy link
Copy Markdown
Author

@aritchie, could you please approve this PR, too?

@aritchie
aritchie merged commit 5d56942 into aritchie:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants