Skip to content

Get the status of the display. #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leonardocavagnis merged 3 commits into from
Mar 17, 2025
Merged

Get the status of the display. #1036

leonardocavagnis merged 3 commits into from
Mar 17, 2025
+41 −0

Conversation

@dmazzella
Copy link
Contributor

@dmazzella dmazzella commented Mar 14, 2025 •
edited
Loading

This functionality expose detect method for obtain the shield status.

Example usage:

void loop() {
  // Display
  if (!Display.detect()) {
    NVIC_SystemReset();
  }

  // LVGL
  lv_timer_handler();

  // IOT CLOUD
  do {
    ArduinoCloud.update();
  } while (block_for_ota);
}

in the production environment we have noticed the loss of connection to the display on the portenta h7 and this modification identifies this problem and allows an action to resolve the problem.

P.S.
the continuous call also unintentionally seems to have solved another vertical image scroll problem that often occurred when resetting the portenta via pin reset or via NVIC_SystemReset();

@dmazzella
Copy link
Contributor Author

dmazzella commented Mar 17, 2025

@leonardocavagnis please take a look at it and let me know.

@leonardocavagnis leonardocavagnis self-requested a review March 17, 2025 08:08
leonardocavagnis
leonardocavagnis requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I suggest renaming the API to detect() for better clarity
Also, please add the function to the API documentation

@dmazzella
Copy link
Contributor Author

dmazzella commented Mar 17, 2025

@leonardocavagnis

about:

the continuous call also unintentionally seems to have solved another vertical image scroll problem that often occurred when resetting the portenta via pin reset or via NVIC_SystemReset();

have you ever experienced this problem on portenta h7?

@leonardocavagnis
Copy link
Member

leonardocavagnis commented Mar 17, 2025

@leonardocavagnis

about:

the continuous call also unintentionally seems to have solved another vertical image scroll problem that often occurred when resetting the portenta via pin reset or via NVIC_SystemReset();

have you ever experienced this problem on portenta h7?

Nope, I haven't experienced it :( but I haven't tested it intensively. Thanks for pointing it out!

At the moment, I can't test the PR. If you confirm that the detect() function is working fine, I'll merge it. :)
Thanks!

@dmazzella
Copy link
Contributor Author

dmazzella commented Mar 17, 2025

@leonardocavagnis
about:

the continuous call also unintentionally seems to have solved another vertical image scroll problem that often occurred when resetting the portenta via pin reset or via NVIC_SystemReset();

have you ever experienced this problem on portenta h7?

Nope, I haven't experienced it :( but I haven't tested it intensively. Thanks for pointing it out!

Ok, thanks

At the moment, I can't test the PR. If you confirm that the detect() function is working fine, I'll merge it. :) Thanks!

I have tested this modification in production environment and work fine for me.

@leonardocavagnis leonardocavagnis merged commit f7ff411 into arduino:main Mar 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardocavagnis leonardocavagnis leonardocavagnis requested changes

Assignees

No one assigned

Labels

Video

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmazzella @leonardocavagnis