Skip to content

feat: improved reference client ip through _APP_TRUSTED_HEADERS #10941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
levivannoort wants to merge 3 commits into
base: 1.8.x
Choose a base branch
from
Draft

feat: improved reference client ip through _APP_TRUSTED_HEADERS #10941

levivannoort wants to merge 3 commits into from
+54 −6

Conversation

@levivannoort
Copy link
Member

@levivannoort levivannoort commented Dec 12, 2025

What does this PR do?

As not to default on the x-forwarded-for header, this pull-request introduces the option to set trusted headers. Which are checked from left to right on request presence wise, where the left most address will be used for as the client reference. With a default set to x-forwarded-for.

To-do:

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch CLO-3704-utopia-request-extend

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@levivannoort levivannoort changed the title Add teamId to project array in e2e test feat: improved reference client ip through _APP_TRUSTED_HEADERS Dec 12, 2025
@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
libpng 1.6.51-r0 CVE-2025-66293 HIGH
libpng-dev 1.6.51-r0 CVE-2025-66293 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 1,126
  • Requests with 200 status code: 202,716
  • P99 latency: 0.172622552

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 1,126 1,173
200 202,716 211,258
P99 0.172622552 0.172701425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@levivannoort