Skip to content
This repository was archived by the owner on Jan 31, 2021. It is now read-only.

default missing query to empty string#77

Open
aryelu wants to merge 1 commit intoapplitools:masterfrom
aryelu:empty-options-query
Open

default missing query to empty string#77
aryelu wants to merge 1 commit intoapplitools:masterfrom
aryelu:empty-options-query

Conversation

@aryelu
Copy link
Copy Markdown

@aryelu aryelu commented Dec 1, 2019

When running MatchWindow

ServerConnector.prototype.matchWindow = function (runningSession, matchWindowData, screenshot) {

SendRequest is invoked with options.query undefined which makes the error reporting crash when the request is failing
that._logger.log(`ServerConnector.${name} - ${method} failed on ${uri}: ${reasonMsg} with params ${JSON.stringify(options.query).slice(0, 100)}`);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant