[#2700] feat(spark): Eager shuffle deletion#2704
Open
zuston wants to merge 11 commits intoapache:masterfrom
Open
[#2700] feat(spark): Eager shuffle deletion#2704zuston wants to merge 11 commits intoapache:masterfrom
zuston wants to merge 11 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2704 +/- ##
=============================================
+ Coverage 0 50.91% +50.91%
- Complexity 0 3271 +3271
=============================================
Files 0 533 +533
Lines 0 25526 +25526
Branches 0 2318 +2318
=============================================
+ Hits 0 12996 +12996
- Misses 0 11700 +11700
- Partials 0 830 +830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roryqi
reviewed
Dec 26, 2025
| import org.apache.spark.scheduler.{SparkListener, SparkListenerStageCompleted, SparkListenerStageSubmitted} | ||
| import org.apache.uniffle.shuffle.manager.RssShuffleManagerBase | ||
|
|
||
| class UniffleStageDependencyListener extends SparkListener with Logging { |
Contributor
There was a problem hiding this comment.
Listener‘s event will be lost sometimes, especially there are huge events.
Member
Author
There was a problem hiding this comment.
This is a known case. Here, the best effort deletion is acceptable.
Contributor
There was a problem hiding this comment.
You should add comments for this point.
Contributor
|
Could u add the documents for this feature? |
Contributor
|
Will it have many deletion strategies? Could u extract interfaces for this feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces the eager shuffle deletion mode to explicitly reduce the whole cluster shuffle storage capacity.
But for the shuffle-reuse scenario, we have to introduce the delayed deletion mechanism to avoid the too-early deletion issue. Anyway this is still an experimental feature and may not cover all edge cases.
Why are the changes needed?
for the issue #2700
Does this PR introduce any user-facing change?
Yes. the option is introduced to enable this feature
spark.rss.client.eagerShuffleDeletion.enabled=falsespark.rss.client.eagerShuffleDeletion.delayedMinutes=20How was this patch tested?
Unit tests