Skip to content

[MINOR] fix(test): Fix flaky test SimpleClusterManagerTest#updateExcludeNodesTest#2331

Open
maobaolong wants to merge 1 commit intoapache:masterfrom
maobaolong:flakyUpdateExcludeNodesTest
Open

[MINOR] fix(test): Fix flaky test SimpleClusterManagerTest#updateExcludeNodesTest#2331
maobaolong wants to merge 1 commit intoapache:masterfrom
maobaolong:flakyUpdateExcludeNodesTest

Conversation

@maobaolong
Copy link
Member

@maobaolong maobaolong commented Jan 8, 2025

What changes were proposed in this pull request?

Fix flaky test SimpleClusterManagerTest#updateExcludeNodesTest

Why are the changes needed?

Error:  Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.317 s <<< FAILURE! - in org.apache.uniffle.coordinator.SimpleClusterManagerTest
Error:  getUnhealthyServerList  Time elapsed: 0.633 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <[sn4, sn2, sn1]> but was: <[sn2, sn1, sn4, sn3]>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
	at org.apache.uniffle.coordinator.SimpleClusterManagerTest.getUnhealthyServerList(SimpleClusterManagerTest.java:219)

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UT

@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Test Results

 2 966 files  ±0   2 966 suites  ±0   6h 28m 59s ⏱️ + 1m 34s
 1 100 tests ±0   1 098 ✅ ±0   2 💤 ±0  0 ❌ ±0 
13 774 runs  ±0  13 744 ✅ ±0  30 💤 ±0  0 ❌ ±0 

Results for commit e611f03. ± Comparison against base commit c14bff7.

cchung100m
cchung100m reviewed Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a workaround solution here?

@maobaolong
Copy link
Member Author

maobaolong commented Jan 12, 2025

Is it a workaround solution here?

@cchung100m Thanks for your review! Actually, no. The purpose of sleep here is specifically to ensure that the file modification time exceeds one second, allowing the subsequent logic to detect a change in the modification time.

roryqi
roryqi reviewed Jan 13, 2025
View reviewed changes
coordinator/src/test/java/org/apache/uniffle/coordinator/SimpleClusterManagerTest.java

final Set<String> nodes2 = Sets.newHashSet("node3-1999", "node4-1999");
// Make sure last modification time change
Thread.sleep(1000);
Copy link
Contributor

@roryqi roryqi Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use Awaitility.await() instead of sleep? We should wait for a condition instead of a fixed interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roryqi roryqi roryqi left review comments

+1 more reviewer

@cchung100m cchung100m cchung100m approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maobaolong @cchung100m @roryqi