This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix t3c cache to invalidate on version change#6883
Merged
Conversation
dd6022c to
77e3576
Compare
ocket8888
suggested changes
Jun 8, 2022
77e3576 to
4fec979
Compare
4fec979 to
8835947
Compare
ocket8888
approved these changes
Jul 15, 2022
ocket8888
left a comment
Contributor
There was a problem hiding this comment.
Sorry, I forgot about this over my vacation
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, both upgrades and downgrades of
trafficcontrol-cache-configcould cause strange issues in config generation, from trying to re-use a cache with incompatibilities resulting in missing or different fields.This fixes t3c to invalidate the cache if the running version is different than the version which created the cache.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run a previous version of t3c, upgrade, verify from log messages and/or HTTP IMS requests that the cache is not used.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
[x] This PR has testsno tests, testing requires HTTP requests and thus can't be unit tested, and integration tests don't support multiple versions yet.[x] This PR has documentationno docs, cache behavior is not documented.