Skip to content

feat: add Kafka support to MeterReportService#243

Merged
Superskyyy merged 3 commits into
apache:masterfrom
jiang1997:feat_meter
Oct 21, 2022
Merged

feat: add Kafka support to MeterReportService#243
Superskyyy merged 3 commits into
apache:masterfrom
jiang1997:feat_meter

Conversation

@jiang1997

@jiang1997 jiang1997 commented Oct 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

#238

OAP accepts MeterDataCollection only now.
Thanks to @Superskyyy's assistance to figure this out.

@wu-sheng wu-sheng added this to the 1.0.0 milestone Oct 18, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Oct 18, 2022
@Superskyyy

Superskyyy commented Oct 18, 2022

Copy link
Copy Markdown
Member

LGTM and congratulations on finishing all parts of the OSPP task! I appreciate your contribution and look forward to more haha.

Superskyyy
Superskyyy reviewed Oct 18, 2022
View reviewed changes
Comment thread skywalking/client/kafka.py Outdated
Superskyyy
Superskyyy requested changes Oct 18, 2022
View reviewed changes
Comment thread tests/e2e/case/kafka/e2e.yaml Outdated
@Superskyyy

Superskyyy commented Oct 18, 2022

Copy link
Copy Markdown
Member

Just some minor stuff, others are good. ^

kezhenxu94
kezhenxu94 previously approved these changes Oct 19, 2022
View reviewed changes

@kezhenxu94 kezhenxu94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address @Superskyyy 's review and LGTM.

@jiang1997

jiang1997 commented Oct 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

LGTM and congratulations on finishing all parts of the OSPP task! I appreciate your contribution and look forward to more haha.

I'm also looking forward to participating AIOps Engine.

@wu-sheng wu-sheng requested a review from Superskyyy October 21, 2022 01:54
@Superskyyy Superskyyy merged commit ca56ad2 into apache:master Oct 21, 2022
@Superskyyy

Superskyyy commented Oct 21, 2022

Copy link
Copy Markdown
Member

Thank you.

@wu-sheng

wu-sheng commented Oct 21, 2022

Copy link
Copy Markdown
Member

@Superskyyy Are we going to have a 1.0.0 release shortly? I noticed there are only 2 left on https://github.com/apache/skywalking/milestone/140

@Superskyyy

Superskyyy commented Oct 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@Superskyyy Are we going to have a 1.0.0 release shortly? I noticed there are only 2 left on apache/skywalking/milestone/140

I think so, the preforking behavior in the remaining issue relates to somewhat weird things in upstream dependencies that cannot be solved easily.

I will try to take another look soon, also do some chores and go for 1.0.0, since our main features are complete by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@Superskyyy Superskyyy Superskyyy approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jiang1997 @Superskyyy @wu-sheng @kezhenxu94