[plugin] pymongo compatible with mongodb cluster#150
Merged
Conversation
replace the `this.collection.database.client.address` with the `this.collection.database.client.nodes` to be compatible with the mongodb cluster
kezhenxu94
approved these changes
Aug 11, 2021
| def _sw_execute(this: _Bulk, *args, **kwargs): | ||
| address = this.collection.database.client.address | ||
| peer = "%s:%s" % address | ||
| nodes = this.collection.database.client.nodes |
Member
There was a problem hiding this comment.
So when the MongoDB is in single-node mode, the this.collection.database.client.nodes will also contain one element?
Member
There was a problem hiding this comment.
I looked at it and the answer is yes.
tom-pytel
reviewed
Aug 11, 2021
tom-pytel
left a comment
Contributor
There was a problem hiding this comment.
I can't comment on this, your call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace the
this.collection.database.client.addresswith thethis.collection.database.client.nodesto be compatible with the mongodb cluster