tornado5+ and tornado6+ support#119
Merged
Merged
Conversation
add tornado5+ and tornado6+ support
kezhenxu94
reviewed
May 30, 2021
kezhenxu94
left a comment
Member
There was a problem hiding this comment.
Hey @probeyang, thanks, can you please also add a case for tornado 5.x in
skywalking-python/tests/plugin/sw_tornado/test_tornado.py
Lines 32 to 34 in c94868b
Contributor
Author
|
Got it! i will add a case for tornado 5.x.
在 2021年5月30日 ***@***.***> 写道：
@kezhenxu94 commented on this pull request.
Hey @probeyang, thanks, can you please also add a case for tornado 5.x in https://github.com/apache/skywalking-python/blob/c94868ba1443890c1d1220d54e8083546e255837/tests/plugin/sw_tornado/test_tornado.py#L32-L34
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
add tornado5.1.1 test case and format tornado plugin code
Contributor
Author
|
add tornado5.1.1 test case and format tornado plugin code |
Member
|
You missed the update of https://github.com/apache/skywalking-python/blob/master/docs/Plugins.md. |
Contributor
|
See #121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add tornado5+ and tornado6+ support