fix: AnnotationEnhancer chain silently discards all modifications#775
Open
lossend wants to merge 1 commit into
Open
fix: AnnotationEnhancer chain silently discards all modifications#775lossend wants to merge 1 commit into
lossend wants to merge 1 commit into
Conversation
…chain The buildEnhancer lambda was accumulating enhanced attributes into newAttrs across all AnnotationEnhancer beans, but then returned the original attrs — making all enhancers silently no-op. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #776
Problem
In
RocketMQMessageListenerBeanPostProcessor.buildEnhancer(), the lambda accumulatesenhanced annotation attributes into
newAttrsacross all registeredAnnotationEnhancerbeans, but then returns the original
attrsinstead ofnewAttrs.This means every
AnnotationEnhancerbean is silently a no-op — its attributemodifications are computed but thrown away.
Fix
Return
newAttrsinstead ofattrs.Root Cause
buildEnhancer()(line 178–184):Impact
Any application that relies on
AnnotationEnhancerto dynamically override@RocketMQMessageListenerattributes (e.g. injecting topic/group from environment properties) will find their customizations have no effect.