Fix ACL hook routing for internal proxy system resources#10372
Open
somiljain2006 wants to merge 2 commits into
Open
Fix ACL hook routing for internal proxy system resources#10372somiljain2006 wants to merge 2 commits into
somiljain2006 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10372 +/- ##
=============================================
- Coverage 48.96% 48.90% -0.07%
- Complexity 13473 13476 +3
=============================================
Files 1376 1378 +2
Lines 100546 100620 +74
Branches 12984 13000 +16
=============================================
- Hits 49236 49211 -25
- Misses 45310 45378 +68
- Partials 6000 6031 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
This PR fixes ACL authentication issues for internal proxy system-resource requests in cluster mode when enableAclRpcHookForClusterMode=true is enabled. Introduced SystemResourceAwareRpcHook and InternalContextHolder to ensure that only trusted internal proxy operations targeting RocketMQ system resources use proxy admin ACL credentials, while normal client requests continue using user credentials.
How Did You Test This Change?
Added comprehensive unit tests covering:
Manual verification was also performed successfully using NameServer + Broker + Proxy with ACL enabled.