Skip to content

[MRRESOURCES-145] Avoid overwriting the generated file with the same content#50

Merged
gnodet merged 3 commits into
apache:masterfrom
gnodet:use-caching-output-stream
Mar 2, 2024
Merged

[MRRESOURCES-145] Avoid overwriting the generated file with the same content#50
gnodet merged 3 commits into
apache:masterfrom
gnodet:use-caching-output-stream

Conversation

@gnodet

@gnodet gnodet commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

@slawekjaranowski slawekjaranowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue will be appreciated - as I understood we will stop overriding output files with the same content.

@gnodet

gnodet commented Feb 26, 2024

Copy link
Copy Markdown
Contributor Author

issue will be appreciated - as I understood we will stop overriding output files with the same content.

I'll raise one, but the effect is rather the opposite. The overwrite flag was effectively removed a while ago, so the filtering mechanism should always ensure that the resource content is copied. The use of a caching output stream avoids writing identical content again and again.

I've just pushed another commit to fix the last execution branch. It'll require a new maven-filtering and I'm planning to release both later this week.

@gnodet gnodet added this to the 3.1.1 milestone Feb 26, 2024
@gnodet gnodet changed the title Use caching output stream [MRRESOURCES-145] Avoid overwriting the generated file with the same content Feb 26, 2024
@gnodet gnodet merged commit 9f5b057 into apache:master Mar 2, 2024
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Mar 11, 2024
@jira-importer

Copy link
Copy Markdown

Resolve #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants