Fix mvnup: use effective model to resolve properties from remote parents#12158
Merged
Conversation
…mvnup The undefined property detection in CompatibilityFixStrategy only performed static analysis of reactor POMs, missing properties inherited from remote parent POMs. This caused valid dependencyManagement entries to be incorrectly commented out, breaking child modules relying on them for version resolution. Now uses buildEffectiveModel to collect properties from the full parent chain, including remote parents resolved via relativePath or Maven repositories. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rmannibucau
approved these changes
Jun 2, 2026
Bukama
approved these changes
Jun 4, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This was referenced Jun 4, 2026
gnodet
added a commit
that referenced
this pull request
Jun 4, 2026
…mvnup (#12158) (#12222) The undefined property detection in CompatibilityFixStrategy only performed static analysis of reactor POMs, missing properties inherited from remote parent POMs. This caused valid dependencyManagement entries to be incorrectly commented out, breaking child modules relying on them for version resolution. Now uses buildEffectiveModel to collect properties from the full parent chain, including remote parents resolved via relativePath or Maven repositories. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompatibilityFixStrategyincorrectly commenting outdependencyManagemententries whose versions use properties inherited from remote parent POMs (e.g.,${oak.version}fromsling-parent,${version}from a published parent)buildEffectiveModelinfrastructure (already available inAbstractUpgradeStrategy) to resolve properties from the full parent chain before deciding a property is "undefined"Fixes gnodet/maven4-testing#13383
Fixes gnodet/maven4-testing#13374
Test plan
CompatibilityFixStrategyTesttests continue to pass🤖 Generated with Claude Code