LUCENE-9940: DisjunctionMaxQuery shouldn't depend on disjunct order for equals checks#110
Merged
Merged
Conversation
jpountz
approved these changes
Apr 29, 2021
janhoy
pushed a commit
to cominvent/lucene
that referenced
this pull request
May 12, 2021
… thread so the PKI Interceptor is activated to allow PULL replicas to replicate from security-enabled leaders (apache#110)
janhoy
pushed a commit
to cominvent/lucene
that referenced
this pull request
May 12, 2021
…r server thread so the PKI Interceptor is activated to allow PULL replicas to replicate from security-enabled leaders (apache#110)" To address review comments after merge. This reverts commit d316946.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisjunctionMaxQuery stores its disjuncts in a
Query[], and usesArrays.equals()for comparisons in itsequals()implementation.This means that the order in which disjuncts are added to the query
matters for equality checks.
This commit changes DMQ to instead store its disjuncts in a Multiset,
meaning that ordering no longer matters. The
getDisjuncts()method now returns a
Collection<Query>rather than aList, andsome tests are changed to use query equality checks rather than
iterating over disjuncts and expecting a particular order.