Skip to content

Add support of the command XGROUP DELCONSUMER#2141

Merged
PragmaTwice merged 4 commits into
apache:unstablefrom
Yangsx-1:xgroup-delconsumer
Mar 9, 2024
Merged

Add support of the command XGROUP DELCONSUMER#2141
PragmaTwice merged 4 commits into
apache:unstablefrom
Yangsx-1:xgroup-delconsumer

Conversation

@Yangsx-1

@Yangsx-1 Yangsx-1 commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Close #1730

This PR add the XGROUP DELCONSUMER command.

@git-hulk git-hulk requested a review from torwig March 7, 2024 07:46
@jihuayu

This comment was marked as outdated.

@sonarqubecloud

sonarqubecloud Bot commented Mar 7, 2024

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@jihuayu jihuayu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk

git-hulk commented Mar 9, 2024

Copy link
Copy Markdown
Member

@torwig Does this PR look good to you? if yes, we can merge since @jihuayu has approved.

@PragmaTwice PragmaTwice merged commit 7d61e94 into apache:unstable Mar 9, 2024
@Yangsx-1 Yangsx-1 deleted the xgroup-delconsumer branch March 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support of the XGROUP CREATECONSUMER and DELCONSUMER

5 participants