GUACAMOLE-2273: Implement FreeRDP AuthenticateEx callback and handle deprecation of Authenticate callback.#670
Open
necouchman wants to merge 3 commits into
Open
GUACAMOLE-2273: Implement FreeRDP AuthenticateEx callback and handle deprecation of Authenticate callback.#670necouchman wants to merge 3 commits into
necouchman wants to merge 3 commits into
Conversation
necouchman
marked this pull request as draft
May 4, 2026 01:44
necouchman
force-pushed
the
jira/2273
branch
2 times, most recently
from
May 4, 2026 15:44
7696572 to
58d152a
Compare
necouchman
marked this pull request as ready for review
May 4, 2026 15:47
Contributor
Author
|
@mike-jumper @corentin-soriano @sschiffli Anyone do a quick review of this? |
necouchman
force-pushed
the
jira/2273
branch
4 times, most recently
from
July 15, 2026 17:37
675b8c4 to
cf038c1
Compare
mike-jumper
reviewed
Jul 15, 2026
…deprecation of Authenticate callback.
mike-jumper
requested changes
Jul 19, 2026
necouchman
force-pushed
the
jira/2273
branch
2 times, most recently
from
July 21, 2026 00:08
1408ed8 to
e0857b8
Compare
mike-jumper
requested changes
Jul 23, 2026
Comment on lines
+534
to
+544
| case AUTH_TLS: | ||
| case AUTH_RDP: | ||
| case AUTH_NLA: | ||
| i = guac_rdp_register_required_auth(settings, params); | ||
| break; | ||
|
|
||
| case GW_AUTH_HTTP: | ||
| case GW_AUTH_RDG: | ||
| case GW_AUTH_RPC: | ||
| i = guac_rdp_register_required_gateway_auth(settings, params); | ||
| break; |
Contributor
There was a problem hiding this comment.
Is there any potential that this callback will be invoked multiple times?
If not, then we're fine. If it can be called multiple times, then these parameters will end up being registered repeatedly until GUAC_ARGV_MAX_REGISTERED is reached.
Contributor
Author
There was a problem hiding this comment.
I think there are a couple of situations where it would be called multiple times:
- If Gateway authentication is requested, it could be call for both Gateway and then Server authentication. That would be twice.
- If authentication fails, the connection would retry, but I don't think this necessarily qualifies as being called multiple times, since the guacd connection would close and then restart when authentication fails.
Is there some way that multiple calls should be dealt with?
necouchman
force-pushed
the
jira/2273
branch
2 times, most recently
from
July 24, 2026 01:05
fae1d07 to
57eb0a0
Compare
…sons; support requesting gateway authentication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the
AuthenticateExcallback for FreeRDP, and handles versions of FreeRDP where theAuthenticatecallback has been deprecated and compiled out.