feat: Introduce metaclass to convert JavaObject and refactor datasource#75
Merged
Merged
Conversation
* Introduce metaclass to convert JavaObject to python easier * Add more detail for datasource including host, port, schema etc * Change else using datasource
zhongjiajie
added a commit
to zhongjiajie/dolphinscheduler
that referenced
this pull request
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 90.93% 90.75% -0.19%
==========================================
Files 61 63 +2
Lines 2218 2314 +96
==========================================
+ Hits 2017 2100 +83
- Misses 201 214 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SbloodyS
approved these changes
Feb 27, 2023
Member
Author
Member
Author
|
may release in version apache/dolphinscheduler:3.1.5 |
zhongjiajie
added a commit
to apache/dolphinscheduler
that referenced
this pull request
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of The Change
Pull Request checklist
I confirm that the following checklist has been completed.
docs/source/config.rstwhen you change filedefault_config.yaml.UPDATING.mdwhen it is an incompatible change.