Skip to content

feat: Add online_schedule for workflow control schedule state#73

Merged
zhongjiajie merged 2 commits into
apache:mainfrom
zhongjiajie:workflow-add-schedule-state-config
Feb 24, 2023
Merged

feat: Add online_schedule for workflow control schedule state#73
zhongjiajie merged 2 commits into
apache:mainfrom
zhongjiajie:workflow-add-schedule-state-config

Conversation

@zhongjiajie

Copy link
Copy Markdown
Member

Brief Summary of The Change

Add parameter online_schedule to control whether the schedule is online or not

close: #71

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@codecov-commenter

codecov-commenter commented Feb 12, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (fa57d68) to head (bdee186).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   90.92%   90.93%   +0.01%     
==========================================
  Files          61       61              
  Lines        2215     2218       +3     
==========================================
+ Hits         2014     2017       +3     
  Misses        201      201              
Flag Coverage Δ
unittests 90.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhongjiajie

Copy link
Copy Markdown
Member Author

we still need to change java code in repo apache/dolphinscheduler

@zhongjiajie

Copy link
Copy Markdown
Member Author

we still need to change java code in repo apache/dolphinscheduler

submit in apache/dolphinscheduler#13551

@zhongjiajie zhongjiajie added the dep-main-repo Dependent on repository apache/dolphinscheduler label Feb 12, 2023
@zhongjiajie zhongjiajie marked this pull request as ready for review February 12, 2023 11:10
@zhongjiajie zhongjiajie merged commit ed1e3c6 into apache:main Feb 24, 2023
@zhongjiajie zhongjiajie deleted the workflow-add-schedule-state-config branch February 24, 2023 07:41
zhongjiajie added a commit to zhongjiajie/dolphinscheduler that referenced this pull request Feb 24, 2023
@zhongjiajie

Copy link
Copy Markdown
Member Author

we still need to change java code in repo apache/dolphinscheduler

submit in apache/dolphinscheduler#13551

may release in version apache/dolphinscheduler:3.1.5

@zhongjiajie zhongjiajie removed the dep-main-repo Dependent on repository apache/dolphinscheduler label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Can not set schedule publish status to online

3 participants