[improve] More pythonic way for parameter local_params in class task #53
Merged
Merged
Conversation
zhongjiajie
reviewed
Dec 16, 2022
zhongjiajie
left a comment
Member
There was a problem hiding this comment.
please remember change the example doc in the end
a1f8b39 to
fca7a19
Compare
2852efe to
9b404dd
Compare
zhongjiajie
reviewed
Dec 19, 2022
zhongjiajie
reviewed
Dec 20, 2022
df452b5 to
f669f24
Compare
f669f24 to
3c4fa31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Summary of The Change
close: #21
Pull Request checklist
I confirm that the following checklist has been completed.
docs/source/config.rstwhen you change filedefault_config.yaml.UPDATING.mdwhen it is an incompatible change.