Skip to content

[Test] Optimize the test cases in the task plugin#46

Merged
zhongjiajie merged 3 commits into
apache:mainfrom
jieguangzhou:cache-task-submit
Dec 16, 2022
Merged

[Test] Optimize the test cases in the task plugin#46
zhongjiajie merged 3 commits into
apache:mainfrom
jieguangzhou:cache-task-submit

Conversation

@jieguangzhou

@jieguangzhou jieguangzhou commented Dec 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Brief Summary of The Change

close: #45

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@jieguangzhou jieguangzhou self-assigned this Dec 16, 2022
@codecov-commenter

codecov-commenter commented Dec 16, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #46 (5ed5a32) into main (8a128a2) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   90.68%   90.71%   +0.02%     
==========================================
  Files          59       59              
  Lines        2073     2090      +17     
==========================================
+ Hits         1880     1896      +16     
- Misses        193      194       +1
Flag Coverage Δ
unittests 90.71% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pydolphinscheduler/core/task.py 93.60% <0.00%> (-0.11%) ⬇️
src/pydolphinscheduler/constants.py 100.00% <0.00%> (ø)
src/pydolphinscheduler/utils/date.py 100.00% <0.00%> (ø)
src/pydolphinscheduler/core/workflow.py 81.86% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie zhongjiajie added the improvement Improve exists function label Dec 16, 2022
zhongjiajie
zhongjiajie approved these changes Dec 16, 2022
View reviewed changes

@zhongjiajie zhongjiajie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, this is a good patch

@zhongjiajie zhongjiajie removed the improvement Improve exists function label Dec 16, 2022
@jieguangzhou jieguangzhou added the improvement Improve exists function label Dec 16, 2022
@zhongjiajie

zhongjiajie commented Dec 16, 2022

Copy link
Copy Markdown
Member

the mergeable bot seem error

@jieguangzhou jieguangzhou removed the improvement Improve exists function label Dec 16, 2022
@zhongjiajie zhongjiajie added enhancement New feature or request improvement Improve exists function and removed enhancement New feature or request labels Dec 16, 2022
@zhongjiajie zhongjiajie merged commit f82e07d into apache:main Dec 16, 2022
@jieguangzhou jieguangzhou added enhancement New feature or request and removed improvement Improve exists function labels Dec 16, 2022
@jieguangzhou jieguangzhou deleted the cache-task-submit branch December 16, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

Assignees

@jieguangzhou jieguangzhou

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Test] Optimize the test cases in the task plugin

3 participants

@jieguangzhou @codecov-commenter @zhongjiajie