Skip to content

fix: missing task_execute_type for task#140

Merged
zhongjiajie merged 4 commits into
apache:mainfrom
zhongjiajie:miss-task_execute_type
Feb 8, 2024
Merged

fix: missing task_execute_type for task#140
zhongjiajie merged 4 commits into
apache:mainfrom
zhongjiajie:miss-task_execute_type

Conversation

@zhongjiajie

Copy link
Copy Markdown
Member

fix: #138

Brief Summary of The Change

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@codecov-commenter

codecov-commenter commented Feb 8, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.88%. Comparing base (b15c716) to head (6842efa).
Report is 5 commits behind head on main.

Files Patch % Lines
src/pydolphinscheduler/core/task.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   90.93%   90.88%   -0.05%     
==========================================
  Files          64       64              
  Lines        2361     2371      +10     
==========================================
+ Hits         2147     2155       +8     
- Misses        214      216       +2     
Flag Coverage Δ
unittests 90.88% <95.55%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongjiajie zhongjiajie self-assigned this Feb 8, 2024
@zhongjiajie zhongjiajie added the bug Something isn't working label Feb 8, 2024
@zhongjiajie zhongjiajie merged commit b568f05 into apache:main Feb 8, 2024
@zhongjiajie zhongjiajie deleted the miss-task_execute_type branch February 19, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workflow defined by python don't create task definition in database

2 participants