Skip to content

[feat] Add token as authentication for python gateway#13

Merged
zhongjiajie merged 6 commits into
apache:mainfrom
zhongjiajie:f-auth-token
Nov 15, 2022
Merged

[feat] Add token as authentication for python gateway#13
zhongjiajie merged 6 commits into
apache:mainfrom
zhongjiajie:f-auth-token

Conversation

@zhongjiajie

@zhongjiajie zhongjiajie commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Brief Summary of The Change

separate from apache/dolphinscheduler#6407. Authentication, add secret to ensure only trusted people could
connect to gateway.

fix: apache/dolphinscheduler#8255
ref: apache/dolphinscheduler#12893

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@zhongjiajie zhongjiajie marked this pull request as ready for review November 14, 2022 10:20
@zhongjiajie zhongjiajie self-assigned this Nov 14, 2022
@zhongjiajie zhongjiajie added enhancement New feature or request dep-main-repo Dependent on repository apache/dolphinscheduler labels Nov 14, 2022
@codecov-commenter

codecov-commenter commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.59%. Comparing base (20b2a2b) to head (74332e5).
Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
src/pydolphinscheduler/configuration.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   90.60%   90.59%   -0.01%     
==========================================
  Files          56       56              
  Lines        2032     2042      +10     
==========================================
+ Hits         1841     1850       +9     
- Misses        191      192       +1
Flag Coverage Δ
unittests 90.59% <90.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jieguangzhou
jieguangzhou approved these changes Nov 15, 2022
View reviewed changes

@jieguangzhou jieguangzhou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie merged commit 0b7c0be into apache:main Nov 15, 2022
@zhongjiajie zhongjiajie deleted the f-auth-token branch November 15, 2022 08:07
@zhongjiajie

zhongjiajie commented Mar 23, 2023

Copy link
Copy Markdown
Member Author

Brief Summary of The Change

separate from apache/dolphinscheduler#6407. Authentication, add secret to ensure only trusted people could connect to gateway.

fix: apache/dolphinscheduler#8255 ref: apache/dolphinscheduler#12893

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

released after apache/dolphinscheduler:3.1.2

@zhongjiajie zhongjiajie removed the dep-main-repo Dependent on repository apache/dolphinscheduler label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieguangzhou jieguangzhou jieguangzhou approved these changes

Assignees

@zhongjiajie zhongjiajie

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][python] Add authentication for python gateway server

3 participants

@zhongjiajie @codecov-commenter @jieguangzhou