Skip to content

feat: Apply PEP-563 for codebase#128

Merged
zhongjiajie merged 5 commits into
apache:mainfrom
zhongjiajie:PEP-563
Dec 25, 2023
Merged

feat: Apply PEP-563 for codebase#128
zhongjiajie merged 5 commits into
apache:mainfrom
zhongjiajie:PEP-563

Conversation

@zhongjiajie

Copy link
Copy Markdown
Member

close: #77

Brief Summary of The Change

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@zhongjiajie zhongjiajie added the chore A collection of chore like CI, remove not used code label Dec 25, 2023
@zhongjiajie zhongjiajie self-assigned this Dec 25, 2023
@codecov-commenter

codecov-commenter commented Dec 25, 2023

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 99.21260% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (1b2ad57) to head (6b66bd8).
Report is 11 commits behind head on main.

Files Patch % Lines
src/pydolphinscheduler/models/datasource.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   90.83%   90.86%   +0.03%     
==========================================
  Files          64       64              
  Lines        2345     2354       +9     
==========================================
+ Hits         2130     2139       +9     
  Misses        215      215              
Flag Coverage Δ
unittests 90.86% <99.21%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongjiajie zhongjiajie merged commit e1d1527 into apache:main Dec 25, 2023
@zhongjiajie zhongjiajie deleted the PEP-563 branch December 25, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A collection of chore like CI, remove not used code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply PEP-563 to our code base

2 participants