Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Feb 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a breaking refactor to improve API consistency by renaming the get_result method to to_sketch for union types. The change affects both HllUnion and CpcUnion, aligning their method names with a clearer, more descriptive convention.
Changes:
- Renamed
HllUnion::get_result()toHllUnion::to_sketch() - Renamed
CpcUnion::get_result()toCpcUnion::to_sketch()(introduced with new CPC sketch support) - Updated all test files and documentation to use the new method name
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| datasketches/src/hll/union.rs | Renamed method from get_result to to_sketch and improved documentation with a period at the end of the summary line |
| datasketches/src/cpc/union.rs | Renamed method from get_result to to_sketch and added comprehensive documentation with examples |
| datasketches/src/hll/mod.rs | Updated module-level documentation example to use to_sketch |
| datasketches/tests/hll_union_test.rs | Updated all test cases to use to_sketch instead of get_result |
| datasketches/tests/cpc_union_test.rs | Updated all test cases to use to_sketch instead of get_result |
| CHANGELOG.md | Documented the breaking change for HllUnion and the new CpcUnion feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @PsiACE @notfilippo