chore: fine tune asfyaml settings#19
Merged
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Dec 15, 2025
Comment on lines
-21
to
-22
| ghp_branch: gh-pages | ||
| ghp_path: /docs |
Member
Author
There was a problem hiding this comment.
.. until we really need it. I guess most of our docs would either go to https://datasketches.apache.org/ or https://docs.rs/datasketches.
tisonkun
commented
Dec 15, 2025
| main: | ||
| required_status_checks: | ||
| contexts: | ||
| - Required |
Member
Author
There was a problem hiding this comment.
It should be "the names of checks". But what "the name" is is vague.
I checked my previous work on Apache Pulsar. Hopefully, we can get it right the first time.
tisonkun
commented
Dec 15, 2025
| contexts: | ||
| - Required | ||
| required_pull_request_reviews: | ||
| required_approving_review_count: 1 |
Member
Author
There was a problem hiding this comment.
It would require a committer's pull request to have one more approving review before merging. But it should be fine as long as we have several active committers overseeing this repo.
Xuanwo
approved these changes
Dec 15, 2025
freakyzoidberg
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #18 to make CI passed.
I can do the rebase once #18 gets merged.