docs(upgrading): document RecursiveQuery schema field in upgrade guide - #23991
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23991 +/- ##
=======================================
Coverage 81.26% 81.26%
=======================================
Files 1110 1110
Lines 384907 384890 -17
Branches 384907 384890 -17
=======================================
- Hits 312808 312796 -12
+ Misses 53634 53626 -8
- Partials 18465 18468 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I merged up to resolve a conflict |
alamb
enabled auto-merge
August 11, 2026 20:49
Contributor
|
Thanks again @AlvaroBalbin |
Contributor
|
the CI seems to have failed due to an infrastrucure error -- I restarted it |
imtherealnaska
pushed a commit
to imtherealnaska/datafusion
that referenced
this pull request
Aug 16, 2026
apache#23991) Adding the `schema` field to `RecursiveQuery` broke downstream code that built the node with a struct literal, and the change was never written up for people upgrading. I added an upgrade guide entry for 55.0.0 that describes what changed, notes it also shipped in 54.1.0 so users on the 54 series find it, and shows how to move to `RecursiveQuery::try_new`. It is documentation only, so whether to revert the change on `branch-54` for 54.2.0 is still an open question. I pushed this to my fork first and the project's own CI workflows pass on the commit. Fixes apache#23886. Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the
schemafield toRecursiveQuerybroke downstream code that built the node with a struct literal, and the change was never written up for people upgrading. I added an upgrade guide entry for 55.0.0 that describes what changed, notes it also shipped in 54.1.0 so users on the 54 series find it, and shows how to move toRecursiveQuery::try_new. It is documentation only, so whether to revert the change onbranch-54for 54.2.0 is still an open question.I pushed this to my fork first and the project's own CI workflows pass on the commit.
Fixes #23886.