Skip to content

Configure GitHub workflows to use concurrency cancel-in-progress for pull requests#401

Merged
garydgregory merged 1 commit into
apache:masterfrom
apupier:addConcurrencyCancelInProgressForPRGitHubWorkflows
Jun 11, 2026
Merged

Configure GitHub workflows to use concurrency cancel-in-progress for pull requests#401
garydgregory merged 1 commit into
apache:masterfrom
apupier:addConcurrencyCancelInProgressForPRGitHubWorkflows

Conversation

@apupier

@apupier apupier commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

see recommended best practices at Apache
https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=GitHub+Actions+Recommended+Practices

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory

Copy link
Copy Markdown
Member

This seem like it will cancel PR runs which is bad.

@apupier

apupier commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

it cancels PR runs if a new commit is pushed to the same branch. usually, the result of the not-last commit of the PR is not useful. (except for credential leaks)

it allows to reduce the load on the shared pool of runners used by Apache projects on GitHub.

@garydgregory

Copy link
Copy Markdown
Member

Ah, I see, thank you for the details.

@garydgregory garydgregory merged commit b273da0 into apache:master Jun 11, 2026
11 checks passed
@apupier apupier deleted the addConcurrencyCancelInProgressForPRGitHubWorkflows branch June 12, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants