[CODEC-340] Fix Base58 custom alphabet handling#437
Open
OldTruckDriver wants to merge 1 commit into
Open
Conversation
Derive a matching decode table from custom Base58 encode tables and use the configured tables when encoding, decoding, and checking the alphabet. Handle leading zero bytes with the first entry of the configured alphabet instead of hard-coding '1'. Reviewed-by: OpenAI Codex Reviewed-by: Anthropic Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Base58.Builder#setEncodeTable(byte...)so custom Base58 alphabets are used consistently for encoding, decoding, leading zero handling, and alphabet checks.Details
Previously, the builder accepted a custom encode table, but
Base58still used the built-in static encode/decode tables internally. This meant custom alphabets were silently ignored.This change derives a matching decode table from custom 58-byte alphabets, validates alphabet length and duplicate entries, and uses the configured alphabet throughout Base58 operations.
Tests
mvn -q -Dtest=org.apache.commons.codec.binary.Base58Test testmvn -q '-Dtest=org.apache.commons.codec.binary.Base58*Test' testmvn -q javadoc:javadocmvn -q