[CODEC-338] Escape literal plus with plusForSpace#432
Open
OldTruckDriver wants to merge 1 commit into
Open
Conversation
When plusForSpace is enabled, decoding treats '+' as a space. Mark '+' as an always-encoded character for that mode so encoding emits a literal plus as %2B and preserves round trips. Reviewed-by: OpenAI Codex Reviewed-by: Anthropic Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[CODEC-338] PercentCodec loses literal '+' when plusForSpace is enabled.
This change makes
PercentCodecpercent-encode a literal'+'as%2BwhenplusForSpaceis enabled. In that mode, decoding treats'+'as a space, so leaving a literal plus unescaped made the encoded output ambiguous and broke round-trip behavior.The fix adds
'+'to the always-encode character set whenplusForSpaceistrue. Spaces are still encoded as'+', while literal plus signs are preserved as%2B.Tests added:
"a+b c"encodes to"a%2Bb+c"and round-trips."a+b"encodes to"a%2Bb"and round-trips, covering the no-space boundary case.Also updates
src/changes/changes.xmlfor CODEC-338.