Skip to content

SystemVM template changes - updated debian version & other changes #9625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohityadavcloud merged 2 commits into from
Sep 4, 2024
Merged

SystemVM template changes - updated debian version & other changes #9625

rohityadavcloud merged 2 commits into from
Sep 4, 2024

Conversation

@sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented Sep 2, 2024 •
edited
Loading

Description

This PR updates SystemVM template debian version to 12.7.0 and other changes below.

  • Update the module dependencies explicitly (depmod -a) for VMware - resolves the iptables and nfs mount issues observed in SSVM & CCPVM.
root@v-1-VM:~# iptables-save
iptables-save/1.8.9 (nf_tables) Failed to initialize nft: Protocol not supported
root@v-1-VM:~#

root@s-2-VM:~# tail -f /var/log/cloud.log
...
2024-09-02T14:19:44,456 WARN  [storage.resource.NfsSecondaryStorageResource] (agentRequest-Handler-4:[]) Execution of process [4162] for command [mount -t nfs -o soft,timeo=133,retrans=2147483647,tcp,acdirmax=0,acdirmin=0 10.0.x.x:/acs/secondary/ref-trl-7233-v-Mol8-suresh-anaparti/ref-trl-7233-v-Mol8-suresh-anaparti-sec1 /mnt/SecStorage/b9cbaeeb-495b-388b-b49d-4c122d9310d8 ] failed.
2024-09-02T14:19:44,457 WARN  [storage.resource.NfsSecondaryStorageResource] (agentRequest-Handler-4:[]) Process [4162] for command [mount -t nfs -o soft,timeo=133,retrans=2147483647,tcp,acdirmax=0,acdirmin=0 10.0.x.x:/acs/secondary/ref-trl-7233-v-Mol8-suresh-anaparti/ref-trl-7233-v-Mol8-suresh-anaparti-sec1 /mnt/SecStorage/b9cbaeeb-495b-388b-b49d-4c122d9310d8 ] encountered the error: [mount.nfs: No such device].
2024-09-02T14:19:44,457 ERROR [storage.resource.NfsSecondaryStorageResource] (agentRequest-Handler-4:[]) Unable to mount 10.0.x.x:/acs/secondary/ref-trl-7233-v-Mol8-suresh-anaparti/ref-trl-7233-v-Mol8-suresh-anaparti-sec1 at /mnt/SecStorage/b9cbaeeb-495b-388b-b49d-4c122d9310d8 due to mount.nfs: No such device
2024-09-02T14:19:44,459 WARN  [cloud.agent.Agent] (agentRequest-Handler-4:[]) Caught: com.cloud.utils.exception.CloudRuntimeException: Failed to get root directory from secondary storage URL [nfs://10.0.x.x/acs/secondary/ref-trl-7233-v-Mol8-suresh-anaparti/ref-trl-7233-v-Mol8-suresh-anaparti-sec1], using NFS version [null], due to [Unable to mount 10.0.x.x:/acs/secondary/ref-trl-7233-v-Mol8-suresh-anaparti/ref-trl-7233-v-Mol8-suresh-anaparti-sec1 at /mnt/SecStorage/b9cbaeeb-495b-388b-b49d-4c122d9310d8 due to mount.nfs: No such device].
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.getRootDir(NfsSecondaryStorageResource.java:2674)
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:2406)
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:297)
	at com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:62)
	at com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:58)
	at com.cloud.agent.Agent.processRequest(Agent.java:679)
	at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:1092)
	at com.cloud.utils.nio.Task.call(Task.java:83)
	at com.cloud.utils.nio.Task.call(Task.java:29)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: com.cloud.utils.exception.CloudRuntimeException: Unable to mount 10.0.x.x:/acs/secondary/ref-trl-7233-v-Mol8-suresh-anaparti/ref-trl-7233-v-Mol8-suresh-anaparti-sec1 at /mnt/SecStorage/b9cbaeeb-495b-388b-b49d-4c122d9310d8 due to mount.nfs: No such device
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.attemptMount(NfsSecondaryStorageResource.java:3080)
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.mount(NfsSecondaryStorageResource.java:3031)
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.mountUri(NfsSecondaryStorageResource.java:3019)
	at org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.getRootDir(NfsSecondaryStorageResource.java:2670)
	... 12 more
systemvm-filesystem-readonly-issue

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.57%. Comparing base (a5f5560) to head (f29db6d).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##               main    #9625     +/-   ##
===========================================
  Coverage     15.57%   15.57%             
- Complexity    12047    12049      +2     
===========================================
  Files          5505     5505             
  Lines        482621   482621             
  Branches      61174    62592   +1418     
===========================================
+ Hits          75176    75184      +8     
+ Misses       399141   399133      -8     
  Partials       8304     8304
Flag Coverage Δ
uitests 4.16% <ø> (ø)
unittests 16.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti
Copy link
Contributor Author

sureshanaparti commented Sep 2, 2024

@blueorangutan package

@rohityadavcloud rohityadavcloud added this to the 4.20.0.0 milestone Sep 3, 2024
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Sep 3, 2024

Packaging isn't required as changes are only in systemvmtemplate codebase. I've kicked Jenkins builds, which should be available shortly at https://build.yadav.cloud/systemvm/

@rohityadavcloud
Copy link
Member

rohityadavcloud commented Sep 3, 2024

build OK

weizhouapache
weizhouapache approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the new systemvm template on ubuntu24 and vmware80u3 manually

#9470 shows that smoke tests worked with the new systemvm template

@sureshanaparti sureshanaparti marked this pull request as ready for review September 4, 2024 05:09
@rohityadavcloud rohityadavcloud merged commit f9c4edc into apache:main Sep 4, 2024
@rohityadavcloud rohityadavcloud deleted the systemvm-tmpl-changes branch September 4, 2024 06:12
@rohityadavcloud
Copy link
Member

rohityadavcloud commented Sep 4, 2024

Merged based on 2lgtms and manual build/tests.

@sureshanaparti sureshanaparti mentioned this pull request Sep 4, 2024
Merged
14 tasks
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024
@sureshanaparti @dhslove
SystemVM template changes - updated debian version & other changes (a…
593c27a 
…pache#9625)

* systemvm template changes, to explicitly update the module dependencies, vmware hardware version updated to 13, fsck added in grub

* Update systemvm template debian version to 12.7
@weizhouapache weizhouapache mentioned this pull request Sep 10, 2024
Closed
@weizhouapache weizhouapache mentioned this pull request Dec 5, 2024
Closed
@sureshanaparti sureshanaparti mentioned this pull request May 8, 2025
Merged
14 tasks
@weizhouapache weizhouapache mentioned this pull request Nov 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@nvazquez nvazquez Awaiting requested review from nvazquez

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:networking component:templates component:virtual-router systemvm-template-change

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sureshanaparti @rohityadavcloud @weizhouapache