Skip to content

CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karuturi merged 1 commit into from
May 8, 2017
Merged

CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume #803

karuturi merged 1 commit into from
May 8, 2017

Conversation

@anshul1886
Copy link

@anshul1886 anshul1886 commented Sep 11, 2015

Update the volume id in volume_store_ref table to newly created volume for migration

@asfbot
Copy link

asfbot commented Sep 11, 2015

cloudstack-pull-rats #572 ABORTED

@yadvr
Copy link
Member

yadvr commented Sep 11, 2015

LGTM

DaanHoogland
DaanHoogland reviewed Sep 11, 2015
View reviewed changes
engine/storage/src/org/apache/cloudstack/storage/image/db/VolumeDataStoreDaoImpl.java
Copy link
Contributor

@DaanHoogland DaanHoogland Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please catch more specific/explicit exceptions. In this case the original exception is not passed through or embedded so it is totally lost.

Copy link
Author

@anshul1886 anshul1886 Sep 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code to embed the exception in CloudRuntimeException.

@asfbot
Copy link

asfbot commented Sep 11, 2015

cloudstack-pull-analysis #508 ABORTED

@asfbot
Copy link

asfbot commented Sep 14, 2015

cloudstack-pull-rats #588 ABORTED

@asfbot
Copy link

asfbot commented Sep 14, 2015

cloudstack-pull-analysis #524 ABORTED

@yadvr
Copy link
Member

yadvr commented Jan 27, 2016

@anshul1886 ping

@yadvr
Copy link
Member

yadvr commented May 2, 2016

@anshul1886 please rebase against latest master and push -f, update on status of your PR

@anshul1886 anshul1886 closed this Feb 23, 2017
@anshul1886 anshul1886 reopened this Feb 23, 2017
@anshulgangwar @anshul-gangwar
CLOUDSTACK-8833: Fixed Generating url and migrate volume to another s…
42b8927 
…torage , resulting two entry in UI and listvolume is not working for that volume

Update the volume id in volume_store_ref table to newly created volume for migration
@anshul1886
Copy link
Author

anshul1886 commented Feb 28, 2017

@rhtyd Rebased against latest master.

@anshul1886 anshul1886 closed this Mar 7, 2017
@anshul1886 anshul1886 reopened this Mar 7, 2017
@priyankparihar
Copy link
Contributor

priyankparihar commented Apr 26, 2017

Hi Guys,
I have tested this PR manually (on master branch). Unable to observe mentioned issue. So please consider it for merging.

@karuturi
Copy link
Member

karuturi commented Apr 26, 2017

@priyankparihar BVT results are required. Can you run CI?

@priyankparihar
Copy link
Contributor

priyankparihar commented Apr 26, 2017

Can you run CI?

@karuturi Running.

@karuturi karuturi modified the milestone: 4.10.0.0 Apr 27, 2017
@karuturi karuturi removed the 4.10.0.0 label Apr 27, 2017
@karuturi
Copy link
Member

karuturi commented May 2, 2017

@priyankparihar Can you run CI again?
There were failures due to #2066 which is nor merged.

@priyankparihar
Copy link
Contributor

priyankparihar commented May 2, 2017

@karuturi

Can you run CI again?

OK Running.

@cloudmonger
Copy link

cloudmonger commented May 2, 2017

ACS CI BVT Run

Sumarry:
Build Number 611
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=1
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

  • test_router_dns.py

  • test_router_dns_guestipquery Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py

@karuturi karuturi merged commit 503c803 into apache:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.10.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@anshul1886 @asfbot @yadvr @priyankparihar @karuturi @cloudmonger @DaanHoogland @anshulgangwar