CLOUDSTACK-8433: Remove awsapi #216

rohityadavcloud · 2015-04-30T15:49:13Z

Following actions from discussions on dev ML regarding removing awsapi and preferring ec2stack. Reference from last PR: #44 Opening a new one as master has changed since then and rebasing caused several conflicts so this PR consists of 3 patches (to make rebasing easier).

- Removes awsapi and awsapi-setup
- Removes awsapi packaging rules for debian, centos63, centos7, fedora 20/21
- Removes catalina port 7080 service configs
- Fixes build replace properties for AWSAPILOG
- Removes maven profile for building awsapi and deploying db in developer profile
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql

CentOS 7, CentOS 6.3, Debian repository: http://packages.bhaisaab.org/cloudstack/nukeawsapi
TravisCI: https://travis-ci.org/apache/cloudstack/builds/60704658

asfbot · 2015-04-30T15:55:14Z

sebgoa on dev@cloudstack.apache.org replies:
Rohit, give me couple days :

1-to get the ec2stack donation finished and the code imported.
2-we should merge this once we agree on a 4.6 release management method.
awsapi and preferring ec2stack. Reference from last PR: =
#44 Opening a new one as master =
has changed since then and rebasing caused several conflicts so this PR =
consists of 3 patches (to make rebasing easier).
fedora 20/21
developer profile
TransactionLegacy
schema-451to460-cleanup.sql
http://packages.bhaisaab.org/cloudstack/nukeawsapi
awsapi and
fedora 20/21
developer profile
path
TransactionLegacy
schema-451to460-cleanup.sql
your
feature
please
ticket

asfbot · 2015-04-30T16:07:52Z

cloudstack-pull-requests #75 FAILURE
Looks like there's a problem with this pull request

asfbot · 2015-04-30T16:09:23Z

cloudstack-pull-requests #74 SUCCESS
This pull request looks good

rohityadavcloud · 2015-04-30T16:12:15Z

@Runseb - Sure. I was testing 4.5 today and the awsapi service did not work for me, after wasting almost 2 hours to make it work, I tried ec2stack which worked out of the box. I thought it would be a good idea to get rid of it and promote ec2stack :)

I’ve split the changes in 3 commits to make it easier to rebase/merge. I’ll keep this open and hope to merge it next week but am interested in merge it now to avoid rebasing efforts again. If ec2stack will get its own git repo like docs repos or cloudmonkey - does it matter if we merge this now or next week and will this block 4.6 release management?

asfbot · 2015-04-30T16:54:00Z

cloudstack-pull-requests #76 SUCCESS
This pull request looks good

asfbot · 2015-04-30T17:23:56Z

cloudstack-pull-requests #77 FAILURE
Looks like there's a problem with this pull request

sebgoa · 2015-04-30T17:34:09Z

-Sebastien

On 30 Apr 2015, at 18:12, Rohit Yadav notifications@github.com wrote:

@Runseb - Sure. I was testing 4.5 today and the awsapi service did not work for me, after wasting almost 2 hours to make it work, I tried ec2stack which worked out of the box. I thought it would be a good idea to get rid of it and promote ec2stack :)

I’ve split the changes in 3 commits to make it easier to rebase/merge. I’ll keep this open and hope to merge it next week but am interested in merge it now to avoid rebasing efforts again. If ec2stack will get its own git repo like docs repos or cloudmonkey - does it matter if we merge this now or next week and will this block 4.6 release management?

Nothing technical, just a better process in my view. To be sure we dont have a period with no official ec2 interface.

Lets talk it over a bit and decide mud next week . That should not causr too much rebase headache.

Ok ?

—
Reply to this email directly or view it on GitHub.

rohityadavcloud · 2015-04-30T17:36:08Z

Copy that.

rohityadavcloud · 2015-05-06T09:42:36Z

@Runseb is this good to go now that ec2stack is an apache cloudstack sub-project? I'll rebase and do some tests again if it's okay merge this PR.

sebgoa · 2015-05-06T09:49:10Z

let's go for it, there has been enough warning. So if you can rebase, make Travis happy….and squash everything that would be good.

sebgoa · 2015-05-06T09:49:47Z

Maybe do it after Daan merges 4.5.1….?

rohityadavcloud · 2015-05-06T11:19:07Z

merging 4.5.1 looks like will cause a lot of conflicts; I'm merging it after rebasing and pushing to master and if travis and packaging works

Following actions from discussions on dev ML regarding removing awsapi and prefering ec2stack. Reference from last PR: #44 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- Removes awsapi packaging rules for debian, centos63, centos7, fedora 20/21 - Removes catalina port 7080 service configs - Fixes build replace properties for AWSAPILOG - Removes maven profile for building awsapi and deploying db in developer profile Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

- Removes awsapi db properties usage across codebase - Removes references from spring xmls, test cases and TransactionLegacy - Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

asfbot · 2015-05-06T13:35:47Z

cloudstack-pull-requests #115 FAILURE
Looks like there's a problem with this pull request

asfbot · 2015-05-06T13:41:48Z

cloudstack-pull-requests #114 SUCCESS
This pull request looks good

It may be useful for users to get some data, so avoid dropping cloudbridge db Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

rohityadavcloud · 2015-05-06T15:12:39Z

All green, merging now.

This closes #216 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

asfbot · 2015-05-06T15:24:38Z

cloudstack-pull-requests #116 SUCCESS
This pull request looks good

* Support RFB 3.8 and VNC auth working * IN PROGRESS: Add TigerVNC classes and authenticate, work left on the messaging * Fix console display * Cleanup * Last in-progress work * Don't block reads in case stream empty, use Link to init client certs (apache#215) Co-authored-by: Marcus Sorensen <mls@apple.com> * Unused files and methods cleanup * Rewrite finished * More cleanup * Rename console server session to VM display name (apache#216) * Rename console server session to VM display name * Fix after rebasing * Add encryption bar when available Co-authored-by: Marcus Sorensen <mls@apple.com> Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com> * Add missing license header * Remove unused variable from the TLS security * Address review comments and sonar cloud reports * Address more review comments * Last sonarcloud code smell fixes * Automate VNC TLS provisioning and improve UI * Add missing cases for sonarcloud report * Fix certs renewal issue on configuring TLS * Address review comments * Refactor serviceConfig script * Fix certs propagation TLS conf * Fix unsecure host tests Co-authored-by: Marcus Sorensen <marcus_sorensen@apple.com> Co-authored-by: Marcus Sorensen <mls@apple.com>

asfgit force-pushed the nuke-awsapi branch from 4435ede to bdfc439 Compare April 30, 2015 15:53

asfgit force-pushed the nuke-awsapi branch from bdfc439 to 79554ef Compare April 30, 2015 16:28

asfgit force-pushed the nuke-awsapi branch from 79554ef to d62a88c Compare April 30, 2015 17:07

asfgit force-pushed the nuke-awsapi branch from d62a88c to 43cfc45 Compare May 6, 2015 11:20

rohityadavcloud added 4 commits May 6, 2015 15:22

CLOUDSTACK-8433: remove awsapi and awsapi-setup

bb86d03

Following actions from discussions on dev ML regarding removing awsapi and prefering ec2stack. Reference from last PR: #44 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

developer: avoid deploying with cloudbridge sqls

b81361c

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

asfgit force-pushed the nuke-awsapi branch from 15e0d1a to b81361c Compare May 6, 2015 13:22

db: don't drop cloudbridge db in schema-451to460-cleanup.sql

0af9c65

It may be useful for users to get some data, so avoid dropping cloudbridge db Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

asfgit merged commit 0af9c65 into master May 6, 2015

asfgit pushed a commit that referenced this pull request May 6, 2015

Merge branch 'nuke-awsapi': Remove awsapi from CloudStack

5af7c35

This closes #216 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

asfgit deleted the nuke-awsapi branch May 6, 2015 15:15

CLOUDSTACK-8433: Remove awsapi #216

CLOUDSTACK-8433: Remove awsapi #216

Uh oh!

Conversation

rohityadavcloud commented Apr 30, 2015

Uh oh!

asfbot commented Apr 30, 2015

Uh oh!

asfbot commented Apr 30, 2015

Uh oh!

asfbot commented Apr 30, 2015

Uh oh!

rohityadavcloud commented Apr 30, 2015

Uh oh!

asfbot commented Apr 30, 2015

Uh oh!

asfbot commented Apr 30, 2015

Uh oh!

sebgoa commented Apr 30, 2015

Uh oh!

rohityadavcloud commented Apr 30, 2015

Uh oh!

rohityadavcloud commented May 6, 2015

Uh oh!

sebgoa commented May 6, 2015

Uh oh!

sebgoa commented May 6, 2015

Uh oh!

rohityadavcloud commented May 6, 2015

Uh oh!

asfbot commented May 6, 2015

Uh oh!

asfbot commented May 6, 2015

Uh oh!

rohityadavcloud commented May 6, 2015

Uh oh!

asfbot commented May 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants