CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class VmwareManagerImpl extends ManagerBase implements VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService, Configurable { | ||
| private static final Logger s_logger = Logger.getLogger(VmwareManagerImpl.class); | ||
|
|
||
| private static final long MILISECONDS_PER_MINUTE = 60000; |
Contributor
There was a problem hiding this comment.
MILI typo MILLISECONDS ..
| if(s_vmwareCleanOldWorderVMs.value() && letsSayNow - startTick > hungWorkerTimeout) { | ||
| if(s_logger.isInfoEnabled()) { | ||
| s_logger.info("Worker VM expired, seconds elapsed: " + (System.currentTimeMillis() - startTick) / 1000); | ||
| } |
Contributor
There was a problem hiding this comment.
For timeouts you may want to use java Duration, that is much cleaner.
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-624 |
Contributor
|
@blueorangutan test centos7 vmware-55u3 |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-983)
|
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-632 |
Contributor
Author
|
renaming and close-opening for retests. "it works on my laptop (tm)" |
Contributor
Author
|
show me the money (tm) |
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-641 |
Contributor
|
Looks like we need to rebase here as well because of the retirement of the Midonet plugin, @DaanHoogland |
e2c0f09 to
084febb
Compare
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-649 |
Contributor
|
@blueorangutan test centos7 vmware-55u3 |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1007)
|
borisstoyanov
approved these changes
Apr 20, 2017
Contributor
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM based on code review, marvin test results and manual verification
Contributor
Author
|
@karuturi @rhtyd @abhinandanprateek @swill @pdion891 can I get a witness? |
Member
|
LGTM |
Contributor
|
LGTM on code review. |
Contributor
|
I can't review much that code, but it look good and seems to fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.