CLOUDSTACK-9502: DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage (include CLOUDSTACK-9386 into 4.9 release branch) #1676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69854e9 to
d7c10fc
Compare
…with multiple clusters and zone wide storage
d7c10fc to
4104cea
Compare
|
@jburwell We just re-run integration tests. The same environment as 1560. |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✖centos7 ✖debian. JID-6 |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-14 |
jburwell
approved these changes
Sep 28, 2016
Contributor
|
LGTM for code review. We are awaiting the results of failures in #1692 to merge smoke tests fixes. When that is completed, we will rebase this PR and execute smoke tests. Upon passage, we will merge this PR. |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-82 |
Contributor
Author
|
Hi @rhtyd @jburwell could this be merged? |
Contributor
|
@blueorangutan test centos6 vmware55u3 |
|
@jburwell a Trillian-Jenkins test job (centos6 mgmt + vmware55u3) has been kicked to run smoke tests |
Contributor
|
@nvazquez kicking regression tests now. If they pass, then I will add my LGTM and merge. |
Contributor
Author
|
Thanks! @jburwell |
Contributor
|
@rhtyd can you check into the status of the test run? |
Member
|
@blueorangutan help @jburwell incorrect hypervisor name provided, as replied earlier bo does not check the passed arguments. I'll fix this. |
|
@rhtyd I understand these words: "help", "hello", "thanks", "package", "test" |
Member
|
Tests have been manually kicked on this now. |
|
Trillian test result (tid-234)
|
Contributor
|
@nvazquez could you please investigate the snapshot test failures? @murali-reddy could you please investigate the VR test failures? These failures appear similar to failures seen on #1681 and #1680? |
|
@jburwell This is most likely blueorangutan issue. This code is already merged into Master via PR1560. We can even cancel this PR and leave it in 4.10 only. |
Contributor
|
@serg38 it may be environmental, but those tests are passing on other PRs in the same environment configuration. Therefore, I would like to determine why it is breaking here sand not elsewhere. |
Contributor
|
@serg38 on what PR was this code merged to master? When we merge this PR, we need to revert and properly forward merge this fix in order to maintain traceability across release branches. |
|
@blueorangutan test vmware-55u3 |
|
@jburwell PR1560. At this point it might be make sense to leave it for 4.10 and not to forward merge it. I checked blueorangutan log and without management server log it is impossible to determine exact reason for the exception. Most likely you had a hypervisor in a failed/disconnected state during the test "Exception: Job failed: {jobprocstatus : 0, created : u'2016-11-01T16:12:54+0000', jobresult : {errorcode : 530, errortext : u'Resource [Host:2] is unreachable: Host 2: Unable to start instance due to Unable to start VM:529663de-7158-4303-9948-5c3ea9f939cc due to error in finalizeStart, not retrying'}, cmd : u'org.apache.cloudstack.api.command.admin.router.RebootRouterCmd', userid : u'896fea80-a00e-11e6-a5b5-0629ca010832', jobstatus : 2, jobid : u'ff89481d-9894-480f-8b15-b678b91baf27', jobresultcode : 530, jobinstanceid : Can we kick off test again? |
Contributor
|
@jburwell VR failures seen are intermittent failures we are seeing w.r.t VPC static routes, RVPC VR in other PR's as well. Not related to the patch. |
Contributor
|
@murali-reddy only the following failures are expected:
The test failures, particularly around storage, are a bit concerning and need to be explained/fixed before merging. I am kicking off another round of tests to help determine whether or not these issues are regressions in the management server (potentially from another commit) or environmental. @blueorangutan test centos6 vmware-55u3 |
|
@jburwell a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-299)
|
|
@jburwell Non-VPC tests on VmWare passed this time. This one seems to be ready for merging. |
asfgit
pushed a commit
that referenced
this pull request
Nov 17, 2016
CLOUDSTACK-9502: DS template copies dont get deleted in VMware ESXi with multiple clusters and zone wide storage (include CLOUDSTACK-9386 into 4.9 release branch)Include #1560 into 4.9 release branch * pr/1676: CLOUDSTACK-9502: DS template copies don’t get deleted in VMware ESXi with multiple clusters and zone wide storage Signed-off-by: John Burwell <meaux@cockamamy.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include #1560 into 4.9 release branch