feat: Do not use regex for simple pattern-replacements to improve performance#252
Merged
hsluoyz merged 1 commit intoapache:masterfrom Dec 10, 2024
Merged
Conversation
|
🎉 This PR is included in version 1.62.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up on #249.
Testing showed significant better performance when not using
std::regexfor simple pattern-replacements.Testimonials
Benchmarks built with CMAKE_BUILD_TYPE=Release in an ubuntu24.04 environment.
Key improvements
Performance of a bunch of benchmarks is improved
BenchmarkRBACModelSmallMaster
Modified version in this PR