Skip to content

Makes Docker directly handle the SIGINT signal#2983

Merged
clenk merged 1 commit into
apache:masterfrom
jbaptperez:docker-signal
Jun 6, 2024
Merged

Makes Docker directly handle the SIGINT signal#2983
clenk merged 1 commit into
apache:masterfrom
jbaptperez:docker-signal

Conversation

@jbaptperez

Copy link
Copy Markdown
Contributor

Description

Caldera needs the SIGINT signal to be properly stopped.
As Docker defaults to the SIGTERM signal, a workaround was, until now, to manually send the SIGINT signal.

This PR makes the Docker image directly set the signal tu use when stopping a related container.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Building a new image and invoking docker stop <container-id> instead of docker kill --signal=SIGINT <container-id>.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@mkultraWasHere mkultraWasHere requested a review from clenk June 5, 2024 21:59
@mkultraWasHere mkultraWasHere self-assigned this Jun 5, 2024
@mkultraWasHere mkultraWasHere added the good submission Quality Contribution (Question/Issue/PR are well explained/documented or impactful) label Jun 5, 2024
@mkultraWasHere

Copy link
Copy Markdown
Contributor

@clenk Im fine with this. Thoughts?

@clenk clenk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clenk clenk merged commit 8d67374 into apache:master Jun 6, 2024
@jbaptperez jbaptperez deleted the docker-signal branch June 9, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good submission Quality Contribution (Question/Issue/PR are well explained/documented or impactful)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants