Skip to content

Fixed golang error with Dockerfile#2802

Merged
mkultraWasHere merged 1 commit into
apache:masterfrom
noperse:master
Oct 19, 2023
Merged

Fixed golang error with Dockerfile#2802
mkultraWasHere merged 1 commit into
apache:masterfrom
noperse:master

Conversation

@noperse

@noperse noperse commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

Description

Was running into an error using the provided Dockerfile, error related to golang.
image

Type of change

Changed from installing go from source, to using apt, this resolved the issue.
image

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running an instance with modified Dockerfile was successful

Please describe the tests that you ran to verify your changes.
docker build . --build-arg WIN_BUILD=true -t caldera:latest
docker-compose up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions

github-actions Bot commented Sep 4, 2023

Copy link
Copy Markdown

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions Bot added the no-pr-activity Needs Attention label Sep 4, 2023
@mkultraWasHere mkultraWasHere removed the no-pr-activity Needs Attention label Sep 7, 2023
@mkultraWasHere mkultraWasHere requested review from clenk, mkultraWasHere and uruwhy and removed request for uruwhy September 7, 2023 21:02

@clenk clenk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. Reason for installing from source was originally that Ubuntu didn't have a recent enough version of Go in their repositories (#2524) but it does now.

@clenk clenk requested review from mkultraWasHere and removed request for mkultraWasHere September 26, 2023 14:45
@clenk

clenk commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

Hmm, actually if we merge in mitre/sandcat#434 then we will have the same issue. The latest docker image is 22.04 which has Golang v1.18 but the sandcat PR will require v1.19. We need to either use the 23.04 docker image as the base, or compile a more recent version of Go from source.

@clenk clenk mentioned this pull request Oct 5, 2023
5 tasks
@mkultraWasHere mkultraWasHere merged commit 151f311 into apache:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants