moved atomic planner into main repo from stockpile#2768
Merged
Conversation
8 tasks
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
Contributor
Author
|
@clenk Take another look |
djlawren
previously approved these changes
Jun 8, 2023
clenk
reviewed
Jun 9, 2023
clenk
left a comment
Contributor
There was a problem hiding this comment.
Should we check the order of the links in test_atomic_0?
Also would be good to give the tests more descriptive names, like test_no_links instead of test_atomic_1
Contributor
Author
|
^ @djlawren (if you have time to handle today) |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving atomic planner to main repo (as a requirement for operations).
*There is a corresponding PR in the stockpile plugin for this planner location change. -> mitre/stockpile#565
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: