revert: downgrade Derby 10.17.1.0 → 10.15.2.0 (Java 19+ incompatibility)#1101
Closed
mateusaubin wants to merge 4 commits intoapache:mainfrom
Closed
revert: downgrade Derby 10.17.1.0 → 10.15.2.0 (Java 19+ incompatibility)#1101mateusaubin wants to merge 4 commits intoapache:mainfrom
mateusaubin wants to merge 4 commits intoapache:mainfrom
Conversation
…#1) - Introduces ArrowFlightProxyDetector: implements gRPC ProxyDetector with multi-level resolution priority * proxyDisable=force override * proxyBypassPattern matching (glob format, case-insensitive) * Explicit proxyHost+proxyPort configuration * ProxySelector.getDefault() fallback - Updates NettyClientBuilder to install proxy detector during channel creation - Extends ArrowFlightConnection/ArrowFlightSqlClientHandler to pass proxy config - Adds comprehensive unit tests for bypass pattern matching and proxy resolution issue: https://linear.app/iomete/issue/CE-208/
* release: bump version to 19.0.0-iomete.1 and add IOMETE manifest - Set all module versions from 19.0.0-SNAPSHOT to 19.0.0-iomete.1 - Add ManifestResourceTransformer to flight-sql-jdbc-driver shade plugin with Built-By, Implementation-Vendor, Implementation-Version, and X-Fork-Source entries identifying this as an IOMETE fork of Arrow 19.0.0 * chore: add build config for JDK 17 * fix: remove machine-specific dotGitDirectory from git-commit-id-plugin config
Bumps org.apache.derby:derby from 10.15.2.0 to 10.17.1.0. --- updated-dependencies: - dependency-name: org.apache.derby:derby dependency-version: 10.17.1.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Derby 10.17.1.0 requires Java 19+ due to internal use of restricted APIs (sun.misc.Unsafe). No backport has been released by the Derby maintainers, despite the fix existing in the repo. The project currently targets Java versions below 19, making this upgrade a build-breaking change. Derby is effectively unmaintained (dead project). Longer-term options discussed during daily sync: - Accept risk: dependency is test-scoped, not shipped to users - Remove Derby from our fork and disable affected tests - Replace with H2 or another embedded DB - Manage our own Derby 10.16.1.2 release - Upgrade arrow-java/JDBC to JDK-21 (would allow keeping 10.17.1.0) Decision: revert for now; track in Vanta noting this is test-scope only and originates from the upstream arrow-java fork. Reverts b8b597a
Author
|
Opened by mistake against upstream; re-opening against iomete/arrow-java fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
10.15.2.0to10.17.1.0sun.misc.UnsafeAPIs — breaks builds on our current JDK targetContext
Derby is a test-scope only dependency in
flight/flight-sql— it is not shipped to users. This was discussed in the daily sync and needs to be annotated in Vanta accordingly.Options considered
10.16.1.2release10.17.1.0; larger scope changeFollow-up
Test plan
flight/flight-sqltests pass with Derby10.15.2.0