feat(csharp/test/Drivers/Databricks): Add mandatory token exchange#3192
Merged
CurtHagenlocher merged 5 commits intoJul 31, 2025
Merged
Conversation
fff5a7c to
8079738
Compare
8079738 to
162c114
Compare
97803c3 to
fc75b07
Compare
fc75b07 to
e80892e
Compare
CurtHagenlocher
approved these changes
Jul 31, 2025
| /// The client ID of the service principal when using workload identity federation. | ||
| /// Default value is empty if not specified. | ||
| /// </summary> | ||
| public const string IdentityFederationClientId = "adbc.databricks.identity_federation_client_id"; |
Contributor
There was a problem hiding this comment.
Can this also be added to the documentation at csharp\src\Drivers\Databricks\readme.md?
I haven't always been paying attention to that, so there may be a bit of a gap now which could be addressed all at once with a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Databricks will eventually require that all non-inhouse OAuth tokens be exchanged for Databricks OAuth tokens before accessing resources. This change implements mandatory token exchange before sending Thrift requests. This check and exchange is performed in the background for now to reduce latency, but it will eventually need to be blocking if non-inhouse OAuth tokens will fail to access Databricks resources in the future.
Key Components
Changes
Testing
dotnet test --filter "FullyQualifiedName~MandatoryTokenExchangeDelegatingHandlerTests"dotnet test --filter "FullyQualifiedName~TokenExchangeClientTests"dotnet test --filter "FullyQualifiedName~JwtTokenDecoderTests"Also tested E2E manually with AAD tokens for Azure Databricks workspaces, AAD tokens for AWS Databricks workspaces, and service principal workload identity federation tokens