Conversation
|
"Just for navigating" across logs this is really useful. But the proposed UX (as well as previous implementation) has the problem that some use cases are made harder:
Otherwise all other changes are fine. |
|
Oh you're right. It messes with scrollable pages. We probably should change it to Shift+arrow so we're not overriding a default behavior. And then do something else for the jump to start/end Yes, we should persist the tab that's selected if its available. Let me work on that in another PR. |
|
Updated to switch normal navigation to shift+Arrow and jump actions to mod+Arrow in order to not override other arrow actions |
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the re-work! Almost perfect, just wanted to approve as I noticed that CTRL+UP/DOWN is now clashing with grid vs. Jumping hotkeys on the log panel :-(
Do we have other modifiers?
|
I tested out a few others and I kept running into conflicts. I decided to just remove jumps altogether. |
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the rework! Looks good now!
* Improve grid kbd navigation * Use chakra tooltip * Fix static checks * Fix static checks * Upgrade keyboard commands to not conflict with regular arrow actions * Remove jump hotkeys * Remove english translation for jump
* Improve grid kbd navigation * Use chakra tooltip * Fix static checks * Fix static checks * Upgrade keyboard commands to not conflict with regular arrow actions * Remove jump hotkeys * Remove english translation for jump
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.