Skip to content

feat: support angular compiler strict templates#353

Merged
beeman merged 1 commit intoangular-split:mainfrom
Harpush:strict-templates-correct-size-type
Sep 3, 2023
Merged

feat: support angular compiler strict templates#353
beeman merged 1 commit intoangular-split:mainfrom
Harpush:strict-templates-correct-size-type

Conversation

@Harpush
Copy link
Collaborator

@Harpush Harpush commented Sep 2, 2023

Fix #220

Features:

  1. size is typed as * or number
  2. number and boolean inputs support strings too (prop="40" and prop="true")
  3. New types: ISplitDirection, ISplitDir, IAreaSize, ISplitUnit
  4. Fully compatible with strict templates considering all above too

@Harpush Harpush requested a review from beeman September 2, 2023 10:36
Copy link
Collaborator

@beeman beeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, happy to merge and publish!

Closes #289

@beeman beeman merged commit 2f77a67 into angular-split:main Sep 3, 2023
@beeman
Copy link
Collaborator

beeman commented Sep 3, 2023

This is now published as angular-split@16.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect @Input size typing when strictTemplates is enabled

2 participants