refactor(@angular-devkit/build-angular): allow @angular/core version 0.0.0#16267
Merged
mgechev merged 1 commit intoangular:masterfrom Nov 22, 2019
gregmagolan:allow_angular_0.0.0
Merged
refactor(@angular-devkit/build-angular): allow @angular/core version 0.0.0#16267mgechev merged 1 commit intoangular:masterfrom gregmagolan:allow_angular_0.0.0
mgechev merged 1 commit intoangular:masterfrom
gregmagolan:allow_angular_0.0.0
Conversation
…0.0.0 Allow version "0.0.0" for integration testing in the angular/angular repository with the generated development @angular/core npm package which is versioned "0.0.0". This is a pre-req for angular/angular#33927 which runs integration tests against the bazel generated npm packages.
clydin
approved these changes
Nov 22, 2019
alan-agius4
approved these changes
Nov 22, 2019
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow version "0.0.0" for integration testing in the angular/angular repository with the generated development @angular/core npm package which is versioned "0.0.0".
This is a pre-req for angular/angular#33927 which runs integration tests against the bazel generated npm packages.
To green up that PR I have a patch that does the same thing https://github.com/angular/angular/pull/33927/files#diff-817b74474f8a65162b6115d04a6f43c7 which will get removed once this change makes it in to the next release